Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Selection plugin #4772

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Template Selection plugin #4772

wants to merge 41 commits into from
+970 −636

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Apr 29, 2024 •
edited by LianaHus
Loading

@yann300 yann300 self-assigned this Apr 29, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit ef5f6ad
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/66a210b58207c20008a45ef4
😎 Deploy Preview https://deploy-preview-4772--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 force-pushed the templates_plugin branch 7 times, most recently from 32d727e to 8112c73 Compare April 30, 2024 13:31
@yann300 yann300 added this to In progress in 0.49.0 - Feature Freeze 20/05 via automation Apr 30, 2024
@yann300 yann300 requested a review from LianaHus April 30, 2024 13:36
@yann300 yann300 force-pushed the templates_plugin branch 11 times, most recently from 1f83797 to 8d683f3 Compare May 1, 2024 11:05
@yann300 yann300 added ready-to-review PR ready to review translation labels May 2, 2024
@Aniket-Engg Aniket-Engg removed this from In progress in 0.49.0 - Feature Freeze 20/05 May 20, 2024
@Aniket-Engg Aniket-Engg added this to In progress in v0.50.0 - Feature Freeze 03/06 via automation May 20, 2024
@Aniket-Engg Aniket-Engg removed this from In progress in v0.50.0 - Feature Freeze 03/06 Jun 4, 2024
joeizang
joeizang requested changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@joeizang joeizang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple errors in the console that should be fixed. See the image included in this comment:
image

Also the buttons don't seem to be off like @Aniket-Engg mentioned.

Aniket-Engg
Aniket-Engg approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeizang joeizang joeizang requested changes

@Aniket-Engg Aniket-Engg Aniket-Engg approved these changes

@LianaHus LianaHus Awaiting requested review from LianaHus

Requested changes must be addressed to merge this pull request.

Assignees

@yann300 yann300

Labels
ready-to-review PR ready to review translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yann300 @Aniket-Engg @LianaHus @joeizang